kevinjqliu commented on code in PR #2826:
URL: https://github.com/apache/iceberg-python/pull/2826#discussion_r2717825658
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -628,6 +641,11 @@ def _fetch_config(self) -> None:
if property_as_bool(self.properties, VIEW_ENDPOINTS_SUPPORTED,
VIEW_ENDPOINTS_SUPPORTED_DEFAULT):
self._supported_endpoints.update(VIEW_ENDPOINTS)
+ separator_from_properties =
self.properties.get(NAMESPACE_SEPARATOR_PROPERTY, DEFAULT_NAMESPACE_SEPARATOR)
+ if not separator_from_properties:
+ raise ValueError("Namespace separator cannot be an empty string")
Review Comment:
this threw me off, i was looking for where decode is used.
i think decode is only applicable on the server side,
https://github.com/apache/iceberg/blob/1a4f423397882b8f7d44c4eb027faf9e5e5fb7bb/core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java#L717-L718
we probably should add it for completeness, but i dont think its a blocker
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
