geruh commented on code in PR #2826:
URL: https://github.com/apache/iceberg-python/pull/2826#discussion_r2715228168
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -628,6 +641,11 @@ def _fetch_config(self) -> None:
if property_as_bool(self.properties, VIEW_ENDPOINTS_SUPPORTED,
VIEW_ENDPOINTS_SUPPORTED_DEFAULT):
self._supported_endpoints.update(VIEW_ENDPOINTS)
+ separator_from_properties =
self.properties.get(NAMESPACE_SEPARATOR_PROPERTY, DEFAULT_NAMESPACE_SEPARATOR)
+ if not separator_from_properties:
+ raise ValueError("Namespace separator cannot be an empty string")
Review Comment:
Java's `RESTUtil.decodeNamespace` detects the legacy `%1F` separator in
existing namespaces even when a new separator is configured. Do we need similar
handling?
https://github.com/apache/iceberg/blob/135659c2d2711a3673a48440609d2e02d8dab376/core/src/main/java/org/apache/iceberg/rest/RESTUtil.java#L329C27-L329C42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
