sarthaksin1857 commented on code in PR #14966:
URL: https://github.com/apache/iceberg/pull/14966#discussion_r2701266291
##########
azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSFileIO.java:
##########
@@ -103,22 +127,30 @@ public Map<String, String> properties() {
}
public DataLakeFileSystemClient client(String path) {
- ADLSLocation location = new ADLSLocation(path);
- return client(location);
+ if (clientSupplier != null) {
Review Comment:
It seems like all the classes which have supplier have caching so it makes
sense to add it here. I pushed a commit which caches just the supplier client
and returns it on subsequent gets.
I did not add caching to the existing code and I did not follow the same map
approach used in the other fileIo classes.
Reasoning for this is scope creep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
