nastra commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2720866577
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -64,13 +67,28 @@ public abstract class S3V4RestSignerClient
extends AbstractAws4Signer<AwsS3V4SignerParams, Aws4PresignerParams>
implements AutoCloseable {
private static final Logger LOG =
LoggerFactory.getLogger(S3V4RestSignerClient.class);
- public static final String S3_SIGNER_URI = "s3.signer.uri";
- public static final String S3_SIGNER_ENDPOINT = "s3.signer.endpoint";
- static final String S3_SIGNER_DEFAULT_ENDPOINT = "v1/aws/s3/sign";
- static final String UNSIGNED_PAYLOAD = "UNSIGNED-PAYLOAD";
- static final String CACHE_CONTROL = "Cache-Control";
- static final String CACHE_CONTROL_PRIVATE = "private";
- static final String CACHE_CONTROL_NO_CACHE = "no-cache";
+
+ /**
+ * @deprecated since 1.11.0, will be removed in 1.12.0; use {@link
CatalogProperties#SIGNER_URI}
+ * instead.
+ */
+ @Deprecated public static final String S3_SIGNER_URI =
CatalogProperties.SIGNER_URI;
Review Comment:
I don't think we can just change the value here as that would break
backwards compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
