nastra commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2720873478
##########
aws/src/test/java/org/apache/iceberg/aws/TestS3FileIOProperties.java:
##########
@@ -225,7 +225,12 @@ public void testS3RemoteSigningEnabled() {
String uri = "http://localhost:12345";;
Map<String, String> properties =
ImmutableMap.of(
- S3FileIOProperties.REMOTE_SIGNING_ENABLED, "true",
CatalogProperties.URI, uri);
+ S3FileIOProperties.REMOTE_SIGNING_ENABLED,
+ "true",
+ CatalogProperties.URI,
+ uri,
+ CatalogProperties.SIGNER_ENDPOINT,
Review Comment:
this wasn't needed before but is needed now, which indicates that this is a
breaking change for users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
