rcjverhoef commented on code in PR #15122:
URL: https://github.com/apache/iceberg/pull/15122#discussion_r2753589111
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -1136,6 +1145,53 @@ public <T extends S3ClientBuilder> void
applyS3AccessGrantsConfigurations(T buil
}
}
+ public <T extends S3ClientBuilder> void applyMetricsPublisherConfiguration(T
builder) {
+ if (metricsPublisherImpl != null) {
+ software.amazon.awssdk.metrics.MetricPublisher metricPublisher =
Review Comment:
question: should this be added to spotless checks as well btw? seems better
to have it signal on the linter than waiting for other humans. is there any
guidelines on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
