steveloughran commented on code in PR #15122:
URL: https://github.com/apache/iceberg/pull/15122#discussion_r2755029822
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -66,6 +67,13 @@ public class S3FileIOProperties implements Serializable {
*/
public static final String CLIENT_FACTORY = "s3.client-factory-impl";
+ /**
+ * This property is used to configure a custom {@link MetricPublisher} for
the S3 client. The
+ * class must implement {@link MetricPublisher} and provide either a static
{@code
Review Comment:
is this link going to resolve? It's in a different library.
It may be best to explicitly say {@code
software.amazon.awssdk.metrics.MetricPublisher} in the first reference and
{@code "MetricPublisher"}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
