rcjverhoef commented on code in PR #15122:
URL: https://github.com/apache/iceberg/pull/15122#discussion_r2757454046
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -66,6 +67,13 @@ public class S3FileIOProperties implements Serializable {
*/
public static final String CLIENT_FACTORY = "s3.client-factory-impl";
+ /**
+ * This property is used to configure a custom {@link MetricPublisher} for
the S3 client. The
+ * class must implement {@link MetricPublisher} and provide either a static
{@code
Review Comment:
I switched both to fully qualified using `@link`. This is inline with the
previous property where we have `{@link
org.apache.iceberg.aws.AwsClientFactory}` (thought that is not an external code
link).
I tried locally after generating API docs, seemed ok. Do let me know if you
really prefer to have `@code`. I don't have a strong preference other than
trying to keep the pattern consistent (let me know if what I am doing is not
consistent btw).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
