pvary commented on a change in pull request #1612:
URL: https://github.com/apache/iceberg/pull/1612#discussion_r526707631
##########
File path: mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -56,10 +62,22 @@ public void initialize(@Nullable Configuration
configuration, Properties serDePr
} else if (serDeProperties.get(InputFormatConfig.TABLE_SCHEMA) != null) {
tableSchema = SchemaParser.fromJson((String)
serDeProperties.get(InputFormatConfig.TABLE_SCHEMA));
} else {
- try {
- tableSchema = Catalogs.loadTable(configuration,
serDeProperties).schema();
- } catch (NoSuchTableException nte) {
- throw new SerDeException("Please provide an existing table or a valid
schema", nte);
+ // Read the configuration parameters
+ String columnNames =
serDeProperties.getProperty(serdeConstants.LIST_COLUMNS);
+ String columnTypes =
serDeProperties.getProperty(serdeConstants.LIST_COLUMN_TYPES);
+ String columnNameDelimiter =
serDeProperties.containsKey(serdeConstants.COLUMN_NAME_DELIMITER) ?
+ serDeProperties.getProperty(serdeConstants.COLUMN_NAME_DELIMITER) :
String.valueOf(SerDeUtils.COMMA);
+ if (columnNames != null && columnTypes != null && columnNameDelimiter !=
null &&
+ !columnNames.isEmpty() && !columnTypes.isEmpty() &&
!columnNameDelimiter.isEmpty()) {
+ tableSchema = HiveSchemaUtil.schema(columnNames, columnTypes,
columnNameDelimiter);
Review comment:
Hive always converts the column/table names to lower case.
Updated the test case to contain some capital letters to test/confirm this.
Good to have a test case for this as well.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
