yyanyy opened a new pull request #1790:
URL: https://github.com/apache/iceberg/pull/1790


   - Similar to #1641 
   - Renamed a few classes to be shared between Parquet and ORC
   - Also noticed an issue where the Spark implementation of 
`TestMergingMetrics ` didn't handle `Date`/`Timestamp` types as expected: they 
don't have matching type in `StructInternalRow.get` and the logic default the 
value to null, and this didn't trigger issue earlier since in the test case 
they were declared as optional fields. ORC Spark writer handles null values 
differently and revealed this problem. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to