danielcweeks commented on code in PR #15368:
URL: https://github.com/apache/iceberg/pull/15368#discussion_r2828705355


##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -867,7 +873,8 @@ public static PlanTableScanResponse planTableScan(
             .withPlanStatus(PlanStatus.COMPLETED)
             .withPlanId(planId)
             .withFileScanTasks(initial.first())
-            .withSpecsById(table.specs());
+            .withSpecsById(table.specs())
+            .withCredentials(DUMMY_STORAGE_CREDENTIALS);

Review Comment:
   I don't think using dummy credentials is the right way to go.  For testing 
the load table credentials, I believe we had a way to set them in the 
environment, which allowed for either not using credentials (insecure 
environments) or providing a single set of credentials that could be used for 
all requests.  That should be good enough for the test harness.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to