nastra commented on code in PR #15368:
URL: https://github.com/apache/iceberg/pull/15368#discussion_r2832660010
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -116,6 +119,9 @@ public class CatalogHandlers {
private static final InMemoryPlanningState IN_MEMORY_PLANNING_STATE =
InMemoryPlanningState.getInstance();
private static final ExecutorService ASYNC_PLANNING_POOL =
Executors.newSingleThreadExecutor();
+ private static final List<Credential> DUMMY_STORAGE_CREDENTIALS =
+ ImmutableList.of(
+ ImmutableCredential.builder().prefix("dummy").putConfig("dummyKey",
"dummyVal").build());
Review Comment:
yeah this was a quick way of verifying the behavior but I agree that we most
likely don't want to add dummy credentials in the reference implementation.
I've moved this away from here and added a specific adapter that returns some
dummy credentials for this single test only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
