nastra commented on code in PR #15368:
URL: https://github.com/apache/iceberg/pull/15368#discussion_r2832665816


##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -867,7 +873,8 @@ public static PlanTableScanResponse planTableScan(
             .withPlanStatus(PlanStatus.COMPLETED)
             .withPlanId(planId)
             .withFileScanTasks(initial.first())
-            .withSpecsById(table.specs());
+            .withSpecsById(table.specs())
+            .withCredentials(DUMMY_STORAGE_CREDENTIALS);

Review Comment:
   I've moved the dummy credentials out of the reference impl into the single 
test by having a custom adapter, so this shouldn't be a concern anymore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to