rdblue commented on code in PR #14101:
URL: https://github.com/apache/iceberg/pull/14101#discussion_r2829655724


##########
api/src/main/java/org/apache/iceberg/expressions/Expressions.java:
##########
@@ -202,6 +204,24 @@ public static UnboundPredicate<String> 
notStartsWith(UnboundTerm<String> expr, S
     return new UnboundPredicate<>(Expression.Operation.NOT_STARTS_WITH, expr, 
value);
   }
 
+  public static UnboundPredicate<ByteBuffer> stIntersects(String name, 
BoundingBox value) {

Review Comment:
   Why is this a `BoundingBox` rather than passing values directly? Should we 
have a version that accepts xmin, xmax, ymin, ymax for simple cases?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to