rdblue commented on code in PR #14101:
URL: https://github.com/apache/iceberg/pull/14101#discussion_r2830404594
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java:
##########
@@ -126,6 +127,16 @@ public <T> R notStartsWith(BoundReference<T> ref,
Literal<T> lit) {
"notStartsWith expression is not supported by the visitor");
}
+ public <T> R stIntersects(BoundReference<T> ref, Literal<ByteBuffer> lit) {
Review Comment:
Why does this only work with `ByteBuffer`? Wouldn't it be better to use
`BoundingBox`?
My guess is that when the expression is bound, the literal gets coerced and
the Java type we used for the geo types is `ByteBuffer`? I think we need to
address this so that we don't deserialize this for every evaluation. This
visitor is called in a tight loop and this would lose a lot of performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
