rdblue commented on code in PR #14101:
URL: https://github.com/apache/iceberg/pull/14101#discussion_r2829662164
##########
api/src/main/java/org/apache/iceberg/expressions/Expressions.java:
##########
@@ -202,6 +204,24 @@ public static UnboundPredicate<String>
notStartsWith(UnboundTerm<String> expr, S
return new UnboundPredicate<>(Expression.Operation.NOT_STARTS_WITH, expr,
value);
}
+ public static UnboundPredicate<ByteBuffer> stIntersects(String name,
BoundingBox value) {
+ return geospatialPredicate(Operation.ST_INTERSECTS, name, value);
+ }
+
+ public static UnboundPredicate<ByteBuffer> stIntersects(
+ UnboundTerm<ByteBuffer> expr, BoundingBox value) {
Review Comment:
What unbound term is this intended to accept? I don't think that we have
anything to pass here other than refs and if that's the case we should remove
this. We don't add anything to the public API that isn't actually needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
