nastra commented on PR #15368: URL: https://github.com/apache/iceberg/pull/15368#issuecomment-3957506997
The alternative to using `TableWithIO` is to pass `FileIO` explicitly next to `Table` everywhere, but the diff turns out quite large, because all scan related classes and subclasses of `BaseReader` need to be adjusted. The other downside is that `FileIO` would need to be broadcasted separately (next to `Table`) in `SparkInputPartition` / `SparkBatch`, so I think having `TableWithIO` makes sense and causes less changes across the codebase but is a bit less explicit about the fact that a different `FileIO` instance is used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
