deniskuzZ commented on code in PR #15389:
URL: https://github.com/apache/iceberg/pull/15389#discussion_r2853175067
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -78,6 +78,7 @@ enum TransactionType {
private TableMetadata base;
private TableMetadata current;
private boolean hasLastOpCommitted;
+ private boolean isAborted = false;
Review Comment:
@qlong, unless you expose `updates` and the rest of the internal mechanics
in `BaseTransaction`, your suggestion doesn’t really help. It would be great if
you could elaborate on a complete solution that doesn’t require a full rewrite
of the Transaction implementation.
I could have copied `BaseTransaction`, and I don’t actually need a
`prepareMetadata()` API as you’re suggesting, but that would result in
significant code duplication.
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -78,6 +78,7 @@ enum TransactionType {
private TableMetadata base;
private TableMetadata current;
private boolean hasLastOpCommitted;
+ private boolean isAborted = false;
Review Comment:
@qlong, unless you expose `updates` and the rest of the internal mechanics
in `BaseTransaction`, your suggestion doesn’t really help. It would be great if
you could elaborate on a complete solution that doesn’t require a full rewrite
of the Transaction implementation.
I could have copied `BaseTransaction`, and I don’t actually need a
`prepareMetadata()` API as you’re suggesting, but that would result in
significant code duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
