RussellSpitzer commented on code in PR #15389:
URL: https://github.com/apache/iceberg/pull/15389#discussion_r2854248878
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -256,21 +258,10 @@ public void commitTransaction() {
hasLastOpCommitted, "Cannot commit transaction: last operation has not
committed");
switch (type) {
- case CREATE_TABLE:
- commitCreateTransaction();
- break;
-
- case REPLACE_TABLE:
- commitReplaceTransaction(false);
- break;
-
- case CREATE_OR_REPLACE_TABLE:
- commitReplaceTransaction(true);
- break;
-
- case SIMPLE:
- commitSimpleTransaction();
- break;
+ case CREATE_TABLE -> commitCreateTransaction();
Review Comment:
While this is pretty and clean, it's not related to this PR, I would save it
for a refactor PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
