mxm commented on code in PR #15433:
URL: https://github.com/apache/iceberg/pull/15433#discussion_r2883052755
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkWriteUtil.java:
##########
@@ -76,6 +76,9 @@ public static SparkWriteRequirements writeRequirements(
private static Distribution writeDistribution(Table table, DistributionMode
mode) {
switch (mode) {
case NONE:
+ // Spark's connector API has no round-robin distribution concept, so
treat it the same
+ // as unspecified and let Spark distribute data across tasks as it
sees fit
+ case ROUND_ROBIN:
return Distributions.unspecified();
Review Comment:
I think we should add an extra case (no fall through) and fail until
round-robin distribution mode is implemented in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
