steveloughran commented on PR #15171: URL: https://github.com/apache/iceberg/pull/15171#issuecomment-3999351721
@danielcweeks I think I've got a good design in #15428 This combines what I was thinking with @adutra's work and tests. Key concept: the whole request is used for the key to the SignedComponent, but the headers we know are fluid/irrelevant have already been stripped out before submission to the rest signing service This means * it is impossible for the signature to cover any header not in the cache key * by excluding fields considered safe (range, referer, user agent, various x-aws-sdk headers) then other requests with changes values in these headers still hit the cache. If the signing service chooses to not sign all of the submitted headers, that's not an issue. It's choice: doesn't affect the caching. What is critical is that the retained headers are considered complete and nothing really important/considered required to sign is left out. @dannycjones : thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
