adutra commented on PR #15171: URL: https://github.com/apache/iceberg/pull/15171#issuecomment-4005586102
@steveloughran @nastra @danielcweeks after many iterations, I've brought this PR to a state that I believe is suitable. It successfully resolves the initial issue while maintaining backward compatibility and good cache efficiency. However, it seems there is strong opposition to the direction taken here. I don't mind closing this PR, but I must point out that the existing caching algorithm is only viable if catalog servers adhere to two unspoken rules: 1. Clients should never be instructed to cache methods other than `GET` and `HEAD`. 2. Signed headers must be "application-scoped"; that is, they must appear with the same value in subsequent requests. This means that request-scoped headers like `range`, `x-amzn-trace-id` cannot be signed, or the server will break the client's cache. Similarly, methods like `PUT` cannot be cached because of the `x-amz-content-sha256` header that is request-scoped, but must be signed. While I find this status quo somewhat fragile, I can accept it and adjust Apache Polaris to comply with these rules. Just let me know 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
