danielcweeks commented on PR #15171: URL: https://github.com/apache/iceberg/pull/15171#issuecomment-3999862381
For reference here's the [lakekeeper implementation](https://github.com/lakekeeper/lakekeeper/blob/main/crates/lakekeeper/src/server/s3_signer/sign.rs) We only cache `HEAD` and `GET` requests as those should be the only ones that are reused in the cache. We can sign for any headers that wouldn't chance across those operations (I thin it only apply to `GET` requests). Other operations shouldn't be cached, so the server can handle what headers it wants to include or not and shouldn't be a concern for the client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
