Guosmilesmile commented on code in PR #15459: URL: https://github.com/apache/iceberg/pull/15459#discussion_r2887680768
########## docs/docs/flink-maintenance.md: ########## @@ -381,6 +415,12 @@ These keys are used in SQL (SET or table WITH options) and are applicable when w | `flink-maintenance.lock.zookeeper.max-sleep-ms` | Maximum sleep time (ms) between retries. Caps the exponential backoff delay. | `10000` | | `flink-maintenance.lock.zookeeper.retry-policy` | Retry policy name for ZooKeeper client. Supported values include: ONE_TIME, N_TIME, BOUNDED_EXPONENTIAL_BACKOFF, UNTIL_ELAPSED, EXPONENTIAL_BACKOFF. | `EXPONENTIAL_BACKOFF` | +- COORDINATOR LOCK + +| Key | Description | Default | +|-----|----------------------|---------| +| `flink-maintenance.lock.type` | Set to `` or not set | | Review Comment: If the coordinator lock will become the default later and the other lock options are removed, I’d prefer not to require users to set this parameter here, so it’s easier and more consistent with their future usage habits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
