pvary commented on code in PR #15459:
URL: https://github.com/apache/iceberg/pull/15459#discussion_r2894962683
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/TestFlinkTableSinkCompaction.java:
##########
@@ -75,15 +78,25 @@ public class TestFlinkTableSinkCompaction extends
CatalogTestBase {
+ "'flink-maintenance.rewrite.rewrite-all'='true',"
+ "'flink-maintenance.rewrite.schedule.data-file-size'='1',"
+ "'flink-maintenance.lock-check-delay-seconds'='60'";
+ private static final String TABLE_PROPERTIES_COORDINATOR =
+ "'flink-maintenance.lock.jdbc.init-lock-table'='true',"
+ + "'flink-maintenance.rewrite.rewrite-all'='true',"
+ + "'flink-maintenance.rewrite.schedule.data-file-size'='1',"
+ + "'flink-maintenance.lock-check-delay-seconds'='60'";
@Parameter(index = 2)
private boolean userSqlHint;
- @Parameters(name = "catalogName={0}, baseNamespace={1}, userSqlHint={2}")
+ @Parameter(index = 3)
+ private String lockType;
+
+ @Parameters(name = "catalogName={0}, baseNamespace={1}, userSqlHint={2},
lockType={3}")
public static List<Object[]> parameters() {
return Arrays.asList(
- new Object[] {"testhadoop_basenamespace", Namespace.of("l0", "l1"),
true},
- new Object[] {"testhadoop_basenamespace", Namespace.of("l0", "l1"),
false});
+ new Object[] {"testhadoop_basenamespace", Namespace.of("l0", "l1"),
true, "jdbc"},
Review Comment:
Could this be `LockConfig.JdbcLockConfig.JDBC`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
