pvary commented on code in PR #15459:
URL: https://github.com/apache/iceberg/pull/15459#discussion_r2894927662
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergSinkCompact.java:
##########
@@ -85,7 +103,7 @@ void before() throws IOException {
tableLoader = CATALOG_EXTENSION.tableLoader();
}
- @Test
+ @TestTemplate
Review Comment:
In one of my PRs it was suggested not to use `TestTemplate` as it was only
introduced for backward compatibility reasons.
I was pointed to use `@ParameterizedTest` for every test instead:
```
@ParameterizedTest
@FieldSource("FILE_FORMATS")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
