rdblue commented on code in PR #15049: URL: https://github.com/apache/iceberg/pull/15049#discussion_r2893147864
########## api/src/main/java/org/apache/iceberg/FileContent.java: ########## @@ -18,11 +18,23 @@ */ package org.apache.iceberg; -/** Content type stored in a file, one of DATA, POSITION_DELETES, or EQUALITY_DELETES. */ +/** + * Content type stored in a file. + * + * <p>For V1-V3 tables: DATA, POSITION_DELETES, or EQUALITY_DELETES. + * + * <p>For V4 tables: DATA, EQUALITY_DELETES, DATA_MANIFEST, or DELETE_MANIFEST. Note that + * POSITION_DELETES is not valid in V4 manifests; deletion vectors are instead represented as Review Comment: I'm not sure that this is accurate. v3 tables that are upgraded to v4 will have position deletes (potentially v2 parquet files and DVs) that are valid. I doubt that we will require rewriting metadata to co-locate, especially when there could be more than one v2 delete file. I think the easiest thing is to choose where to document these requirements/restrictions. And this isn't a great place for them. This should define what each one means and possibly when it was added, but not how to use it across formats. The restrictions for what can be written into v4 files should be located with the v4 writers an in `V4Metadata`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
