rdblue commented on code in PR #15049: URL: https://github.com/apache/iceberg/pull/15049#discussion_r2893174742
########## core/src/main/java/org/apache/iceberg/DvInfo.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import org.apache.iceberg.types.Types; + +/** + * Metadata about a deletion vector (DV) associated with a data file entry. + * + * <p>In the combined entry model, each DATA entry may optionally carry DV information. The DV + * content is stored at the specified location, offset, and size. + * + * <p>This struct may only be defined when content_type is DATA (0), and must be null for all other + * content types. + */ +interface DvInfo { Review Comment: Iceberg doesn't follow Java's convention to use CamelCase for acronyms. Instead, names with acronyms like `FileIO` capitalize each letter. The exception is for "ID" as in `fieldId`, but almost all other cases should leave acronyms capitalized. Here, it should be `DVInfo`. Also, is there a better noun than "info" for this? There's "descriptor" or "handle", but I don't really care for those. It seems strange to use "info". Other places in the spec are named after what is being tracked, like "data_file" or "snapshot". Maybe we should use "DeletionVector" here? That would fit with the other uses. Another option is "DVRef" because this is pointing to a slice of a file (shouldn't be `DVFile`). What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
