rdblue commented on code in PR #15049:
URL: https://github.com/apache/iceberg/pull/15049#discussion_r2893149672
##########
api/src/main/java/org/apache/iceberg/FileContent.java:
##########
@@ -18,11 +18,23 @@
*/
package org.apache.iceberg;
-/** Content type stored in a file, one of DATA, POSITION_DELETES, or
EQUALITY_DELETES. */
+/**
+ * Content type stored in a file.
+ *
+ * <p>For V1-V3 tables: DATA, POSITION_DELETES, or EQUALITY_DELETES.
+ *
+ * <p>For V4 tables: DATA, EQUALITY_DELETES, DATA_MANIFEST, or
DELETE_MANIFEST. Note that
+ * POSITION_DELETES is not valid in V4 manifests; deletion vectors are instead
represented as
+ * optional DV info on DATA entries.
+ */
public enum FileContent {
DATA(0),
POSITION_DELETES(1),
- EQUALITY_DELETES(2);
+ EQUALITY_DELETES(2),
+ /** Data manifest entry (V4+ only) - references data files in a root
manifest. */
Review Comment:
The v4 comments here are duplicative and probably not in the right place
anyway. Let's focus docs here on what these things mean, not how they can be
used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
