openinx commented on a change in pull request #1818:
URL: https://github.com/apache/iceberg/pull/1818#discussion_r530148007
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -64,22 +66,25 @@ public static TableMetadata
newTableMetadata(TableOperations ops,
PartitionSpec spec,
String location,
Map<String, String> properties)
{
- return newTableMetadata(schema, spec, SortOrder.unsorted(), location,
properties, DEFAULT_TABLE_FORMAT_VERSION);
+ int formatVersion = PropertyUtil.propertyAsInt(properties, FORMAT_VERSION,
FORMAT_VERSION_DEFAULT);
+ return newTableMetadata(schema, spec, SortOrder.unsorted(), location,
properties, formatVersion);
Review comment:
OK, I can change to use the `TestTables` to test the format v2. If we
think all of the v2 work are finished, then we open to expose it to users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
