openinx commented on a change in pull request #1818:
URL: https://github.com/apache/iceberg/pull/1818#discussion_r530171649
##########
File path:
data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java
##########
@@ -95,4 +102,24 @@ public GenericAppenderFactory setAll(Map<String, String>
properties) {
throw new UncheckedIOException(e);
}
}
+
+ @Override
+ public org.apache.iceberg.io.DataWriter<Record>
newDataWriter(EncryptedOutputFile file, FileFormat format,
+ StructLike
partition) {
+ return new org.apache.iceberg.io.DataWriter<>(
+ newAppender(file.encryptingOutputFile(), format), format,
+ file.encryptingOutputFile().location(), spec, partition,
file.keyMetadata());
+ }
+
+ @Override
+ public EqualityDeleteWriter<Record> newEqDeleteWriter(EncryptedOutputFile
outputFile, FileFormat format,
+ StructLike partition) {
+ throw new UnsupportedOperationException("Cannot create equality-delete
writer for generic record now.");
Review comment:
I expected to provide the implemented methods with complete coverage
unit tests. But for the purpose providing the PoC solution as soon as possible,
I did't have the time to write those tests so left them unsupported now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
