openinx commented on a change in pull request #1818:
URL: https://github.com/apache/iceberg/pull/1818#discussion_r530174989
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/sink/IcebergStreamWriter.java
##########
@@ -62,7 +62,7 @@ public void open() {
@Override
public void prepareSnapshotPreBarrier(long checkpointId) throws Exception {
// close all open files and emit files to downstream committer operator
- for (DataFile dataFile : writer.complete()) {
+ for (DataFile dataFile : writer.complete().dataFiles()) {
Review comment:
Yes, it should be emit the `deleteFiles` to downstream, and commit both
delete files and data files into iceberg table by `RowDelta` API. I think that
would be a separate PR to address this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
