rdblue commented on code in PR #15595:
URL: https://github.com/apache/iceberg/pull/15595#discussion_r2927939969
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -180,25 +177,27 @@ public CloseableIterable<FileScanTask> planFiles() {
private CloseableIterable<FileScanTask> planTableScan(PlanTableScanRequest
planTableScanRequest) {
PlanTableScanResponse response =
client.post(
- resourcePaths.planTableScan(tableIdentifier),
+ planTableScanPath,
planTableScanRequest,
PlanTableScanResponse.class,
- headers,
+ headers.get(),
ErrorHandlers.tableErrorHandler(),
stringStringMap -> {},
parserContext);
this.planId = response.planId();
PlanStatus planStatus = response.planStatus();
if (null != planId && !response.credentials().isEmpty()) {
- this.fileIOForPlanId = fileIOForPlanId(response.credentials());
+ this.fileIOForPlanId = scanFileIO(response.credentials());
}
switch (planStatus) {
case COMPLETED:
return scanTasksIterable(response.planTasks(),
response.fileScanTasks());
case SUBMITTED:
- Endpoint.check(supportedEndpoints, Endpoint.V1_FETCH_TABLE_SCAN_PLAN);
+ Preconditions.checkState(
+ supportsAsync,
+ "Invalid plan status SUBMITTED: server does not support async scan
planning");
Review Comment:
`SUBMITTED` is not a valid status. It is `submitted` and I think it is
important to be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
