rdblue commented on code in PR #15595:
URL: https://github.com/apache/iceberg/pull/15595#discussion_r2933596003
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -598,6 +598,9 @@ private RESTTable restTableForScanPlanning(
TableOperations ops, TableIdentifier finalIdentifier, RESTClient
restClient) {
// server supports remote planning endpoint and server / client wants to
do server side planning
if (endpoints.contains(Endpoint.V1_SUBMIT_TABLE_SCAN_PLAN) &&
restScanPlanningEnabled) {
+ boolean supportsAsync =
endpoints.contains(Endpoint.V1_FETCH_TABLE_SCAN_PLAN);
Review Comment:
I would say being able to handle the "submitted" but not "completed" status
is a reasonable definition of "async". And I wouldn't say
`supportsFetchPlanningResult` is actually more clear. In the planning APIs, we
use "fetch" to refer to the endpoint where you fetch the result of a plan task.
I personally find it hard when I see "fetch planning result" vs "fetch plan
task result". These are too similar to be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
