rdblue commented on code in PR #15595:
URL: https://github.com/apache/iceberg/pull/15595#discussion_r2928006858
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -92,30 +88,29 @@ class RESTTableScan extends DataTableScan {
Schema schema,
TableScanContext context,
RESTClient client,
- Map<String, String> headers,
- TableOperations operations,
- TableIdentifier tableIdentifier,
- ResourcePaths resourcePaths,
- Set<Endpoint> supportedEndpoints,
- FileIO tableIO,
- Map<String, String> catalogProperties,
- Object hadoopConf) {
+ Supplier<Map<String, String>> headers,
+ String planTableScanPath,
+ Function<String, String> planPath,
+ String fetchScanTasksPath,
+ boolean supportsAsync,
+ boolean supportsCancel,
+ boolean supportsFetchTasks,
+ BiFunction<List<StorageCredential>, Map<String, String>, FileIO>
fileIOFactory) {
super(table, schema, context);
- this.table = table;
this.client = client;
this.headers = headers;
- this.operations = operations;
- this.tableIdentifier = tableIdentifier;
- this.resourcePaths = resourcePaths;
- this.supportedEndpoints = supportedEndpoints;
+ this.planTableScanPath = planTableScanPath;
+ this.planPath = planPath;
+ this.fetchScanTasksPath = fetchScanTasksPath;
+ this.supportsAsync = supportsAsync;
+ this.supportsCancel = supportsCancel;
+ this.supportsFetchTasks = supportsFetchTasks;
this.parserContext =
Review Comment:
Minor: Rather than creating this every time this is refined, it would be
better to create it lazily and reuse it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
