zeroshade commented on code in PR #795:
URL: https://github.com/apache/iceberg-go/pull/795#discussion_r2961335043
##########
catalog/rest/rest.go:
##########
@@ -907,6 +943,7 @@ func (r *Catalog) RegisterTable(ctx context.Context,
identifier table.Identifier
config := maps.Clone(r.props)
maps.Copy(config, ret.Metadata.Properties())
maps.Copy(config, ret.Config)
+ maps.Copy(config, resolveStorageCredentials(ret.StorageCredentials,
ret.MetadataLoc))
Review Comment:
i haven't looked into it much yet, but do the storage-credentials keys match
what would be expected in the config for the credentials? or do we need to have
a separate member for managing these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
