rockwotj commented on code in PR #795:
URL: https://github.com/apache/iceberg-go/pull/795#discussion_r2962422025
##########
catalog/rest/rest.go:
##########
@@ -675,16 +685,41 @@ func checkValidNamespace(ident table.Identifier) error {
return nil
}
-func (r *Catalog) tableFromResponse(ctx context.Context, identifier []string,
metadata table.Metadata, loc string, config iceberg.Properties) (*table.Table,
error) {
+func (r *Catalog) tableFromResponse(_ context.Context, identifier []string,
metadata table.Metadata, loc string, config iceberg.Properties) (*table.Table,
error) {
+ refresher := &vendedCredentialRefresher{
Review Comment:
I'm kicking off a couple hour test with polaris on aws to ensure the
credential fetching works, but now we only do credential fetching if storage
credentials field is populated from the catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
