rockwotj commented on code in PR #795:
URL: https://github.com/apache/iceberg-go/pull/795#discussion_r2962186870
##########
catalog/rest/rest.go:
##########
@@ -907,6 +943,7 @@ func (r *Catalog) RegisterTable(ctx context.Context,
identifier table.Identifier
config := maps.Clone(r.props)
maps.Copy(config, ret.Metadata.Properties())
maps.Copy(config, ret.Config)
+ maps.Copy(config, resolveStorageCredentials(ret.StorageCredentials,
ret.MetadataLoc))
Review Comment:
yes they are expected to match (I also tested this with polaris and cred
vendoring overnight)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
