sqd commented on code in PR #15433:
URL: https://github.com/apache/iceberg/pull/15433#discussion_r2969802304
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecord.java:
##########
@@ -59,7 +74,7 @@ public DynamicRecord(
Schema schema,
RowData rowData,
PartitionSpec partitionSpec,
- DistributionMode distributionMode,
+ @Nullable DistributionMode distributionMode,
int writeParallelism) {
Review Comment:
Good point. I changed this and reworded the other constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
