Guosmilesmile commented on code in PR #15675:
URL: https://github.com/apache/iceberg/pull/15675#discussion_r2980784011
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -73,6 +76,11 @@ public abstract class BaseFormatModelTests<T> {
protected abstract void assertEquals(Schema schema, List<T> expected,
List<T> actual);
+ protected abstract Object convertConstantToEngine(Types.NestedField field,
Object value);
Review Comment:
I have tried it. When I add partitionData to idToConstant, the Flink side
requires it to be a Record. The RowDataConverter.convert used in
convertToEngine will force the STRUCT to be converted to a Record and throw an
error. For metadata processing on the Flink side, RowDataUtil.convertConstant
is used
instead.https://github.com/apache/iceberg/blob/05186517662ef6fbd8ae6bd60b6e3e311bf16609/flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/RowDataConverter.java#L114-L115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
