pvary commented on code in PR #15675:
URL: https://github.com/apache/iceberg/pull/15675#discussion_r2983018067
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -719,4 +1205,15 @@ private static String splitSizeProperty(FileFormat
fileFormat) {
"No split size property defined for format: " + fileFormat);
};
}
+
+ private Map<Integer, Object> convertConstantsToEngine(
Review Comment:
This is too convoluted and we still need an `getFieldFromEngineRow`, so we
are not much better of.
If we still need the extra method, we might be better of having a method
like:
```
public static Object convertConstantsToEngine(Type type, Object value);
```
For Spark it could simply call `SparkUtil.internalToSpark`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
