Guosmilesmile commented on code in PR #15675:
URL: https://github.com/apache/iceberg/pull/15675#discussion_r2982100349
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -73,6 +76,11 @@ public abstract class BaseFormatModelTests<T> {
protected abstract void assertEquals(Schema schema, List<T> expected,
List<T> actual);
+ protected abstract Object convertConstantToEngine(Types.NestedField field,
Object value);
+
+ protected abstract <D> List<D> convertToPartitionIdentity(
Review Comment:
Along with the aforementioned changes, this part has also been optimized
away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
