yyanyy commented on a change in pull request #1790:
URL: https://github.com/apache/iceberg/pull/1790#discussion_r533839928
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java
##########
@@ -383,7 +383,7 @@ private static boolean isSameType(TypeDescription orcType,
Type icebergType) {
.map(Integer::parseInt);
}
- static int fieldId(TypeDescription orcType) {
+ public static int fieldId(TypeDescription orcType) {
Review comment:
I think `GenericOrcWriter` is still currently using it and it's in
`org.apache.iceberg.data.orc` but this method is in `org.apache.iceberg.orc`,
so we will still have to declare public...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
