rdblue commented on a change in pull request #1790:
URL: https://github.com/apache/iceberg/pull/1790#discussion_r533754996
##########
File path: orc/src/main/java/org/apache/iceberg/orc/OrcRowWriter.java
##########
@@ -35,4 +37,12 @@
* @throws IOException if there's any IO error while writing the data value.
*/
void write(T row, VectorizedRowBatch output) throws IOException;
+
+ /**
+ * Returns a stream of {@link FieldMetrics} that this OrcRowWriter keeps
track of.
+ * <p>
+ * Since ORC keeps track of most metrics via column statistics, for now
OrcRowWriter only keeps track of NaN
+ * counters for double or float columns.
Review comment:
I don't think this paragraph needs to be here because it is a snapshot
of how another component works. It could get stale really easily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
