yyanyy commented on a change in pull request #1790:
URL: https://github.com/apache/iceberg/pull/1790#discussion_r533834476
##########
File path: flink/src/main/java/org/apache/iceberg/flink/data/FlinkOrcWriter.java
##########
@@ -46,8 +50,8 @@ private FlinkOrcWriter(RowType rowType, Schema iSchema) {
}
}
- public static OrcRowWriter<RowData> buildWriter(RowType rowType, Schema
iSchema) {
- return new FlinkOrcWriter(rowType, iSchema);
+ public static OrcRowWriter<RowData> buildWriter(RowType rowType, Schema
iSchema, TypeDescription schema) {
Review comment:
Thanks for the info! Yeah earlier I noticed that the ids exist in
`NestedField ` but wasn't able to find out a good way to extract without larger
changes to the signature, and tried to replace `StructType`/`NestedType` with
`NestedField` but that would result in losing other information. I'll update to
use the before/after pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
