dramaticlly commented on code in PR #16108:
URL: https://github.com/apache/iceberg/pull/16108#discussion_r3260581466
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -775,9 +733,9 @@ private List<ManifestFile> writeDeleteFileGroup(
return writer.toManifestFiles();
}
- private static <F> List<ManifestFile> writeManifests(
+ private <F> List<ManifestFile> writeManifests(
Review Comment:
removed static as we not require to access the commitPoolSized for instance
variable, also this method is called during apply() which is already
single-threaded per snapshot operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
