stevenzwu commented on code in PR #16108:
URL: https://github.com/apache/iceberg/pull/16108#discussion_r3283905970
##########
api/src/main/java/org/apache/iceberg/SnapshotUpdate.java:
##########
@@ -60,6 +60,21 @@ public interface SnapshotUpdate<ThisT> extends
PendingUpdate<Snapshot> {
*/
ThisT scanManifestsWith(ExecutorService executorService);
+ /**
+ * Use a particular executor to write manifests during commit. The default
worker pool will be
+ * used by default.
+ *
+ * <p>Implementations may require a specific executor type (such as {@link
+ * java.util.concurrent.ThreadPoolExecutor}) to derive parallelism for
manifest writes.
+ *
+ * @param executorService the provided executor
+ * @return this for method chaining
+ */
+ default ThisT commitManifestsWith(ExecutorService executorService) {
Review Comment:
I unresolved this comment for visibility to other reviewers on the API
design choices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
