huaxingao commented on code in PR #16108:
URL: https://github.com/apache/iceberg/pull/16108#discussion_r3261046119
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -123,6 +123,8 @@ public void accept(String file) {
SnapshotAncestryValidator.NON_VALIDATING;
private ExecutorService workerPool;
+ private ExecutorService commitPool = ThreadPools.getWorkerPool();
Review Comment:
nit: should we make this lazy init too to match `workerPool` above?
```
private ExecutorService commitPool;
protected ExecutorService commitPool() {
if (commitPool == null) {
this.commitPool = ThreadPools.getWorkerPool();
}
return commitPool;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
