xanderbailey commented on code in PR #2453:
URL: https://github.com/apache/iceberg-rust/pull/2453#discussion_r3323245108
##########
crates/iceberg/src/spec/table_properties.rs:
##########
@@ -128,6 +128,11 @@ pub struct TableProperties {
pub cdc_max_chunk_size: usize,
/// Content-defined chunking normalization level (gearhash bit adjustment).
pub cdc_norm_level: i32,
+ /// The master key id used to encrypt this table's manifest list and data
+ /// files. `None` if `encryption.key-id` is not set.
+ pub encryption_key_id: Option<String>,
Review Comment:
I don't know if `...TableProperties` is valid rust is it? Do you mean copy
all of the fields out and have an enum for table properties? Seems like adding
a new struct here would just be added indirection, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
