blackmwk commented on code in PR #2453:
URL: https://github.com/apache/iceberg-rust/pull/2453#discussion_r3362527913
##########
crates/iceberg/src/encryption/manager.rs:
##########
@@ -105,6 +105,47 @@ impl fmt::Debug for EncryptionManager {
}
impl EncryptionManager {
+ /// Attempt to construct an [`EncryptionManager`] from table metadata.
+ ///
+ /// Returns `Ok(None)` if the format version is below v3 or the
+ /// `encryption.key-id` property is not set. Returns an error if the
+ /// property is set but no [`KeyManagementClient`] was provided.
+ pub fn from_table_metadata(
Review Comment:
```suggestion
pub(crate) fn from_table_metadata(
```
This is used internally.
##########
crates/iceberg/testdata/table_metadata/TableMetadataV2ValidEncryption.json:
##########
Review Comment:
Do we really need this? I think we already have valid v2 non encryption
table metadata files?
##########
crates/iceberg/testdata/table_metadata/TableMetadataV3ValidEncryption.json:
##########
Review Comment:
This is not encrypted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
